Issue 734 - reviewboard - Site Settings change requires Apache restart - Web-based code review tool

Issue 734:	Site Settings change requires Apache restart
	3 people starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	chip...@gmail.com
Closed:	Apr 2009
Type-Defect Priority-Critical Milestone-Release1.0 Component-Settings

Reported by matthewt...@gmail.com, Nov 13, 2008

*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
http://review.morristechnology.com/admin/settings/email/
http://review.morristechnology.com/admin/db/siteconfig/siteconfiguration/1/

What steps will reproduce the problem?
1. Change a setting on the first link and Save.
2. Notice the Email settings do not APPEAR to have been saved, but...
3. Visiting the second URL and viewing the config value reveals it has.
4. Restarting Apache syncs both the email settings form and the config form
value.

What is the expected output? What do you see instead?
Expected the Email settings to update immediately after being changed.

What operating system are you using? What browser?
Windows XP Professional, Firefox 3.0.3

Please provide any additional information below.
This may not be a bug per se, in fact it may be the intended functionality.
 I'm filing this as a precautionary measure.

Thanks for your time, and great work!
Matt

Comment 1 by project member chip...@gmail.com, Nov 13, 2008

How recently have you updated Djblets and Review Board? We put out a fix for this a
few days ago.

Comment 2 by instantn...@gmail.com, Nov 13, 2008

I can confirm this bug. Change of settings don't appear to do anything. If I access
same setting page again I get random results - either old one before change or new
one after change (sometimes even template error page). After restarting apache
everything is back to normal and changed settings are updated.

My reviewboard version:
Fetching external item into 'djblets'
External at revision 11906.

Fetching external item into 'django_evolution'
External at revision 164.

Fetching external item into 'htdocs/media/djblets'
External at revision 11906.

At revision 1571.

Comment 3 by project member chip...@gmail.com, Nov 25, 2008

I had thought we had fixed this.. Guess not.

Status: Confirmed
Labels: -Priority-Medium Priority-Critical Milestone-Release1.0 Component-Settings

Comment 4 by project member trowb...@gmail.com, Feb 9, 2009

This should be fixed now.

Status: Fixed

Comment 5 by project member chip...@gmail.com, Feb 9, 2009

Sadly, no. There's still some issues that happen on occasion. I haven't figured it
out yet. I saw this just the other day.

Status: Confirmed
Owner: chipx86

Comment 6 by project member chip...@gmail.com, Mar 25, 2009

 Issue 966  has been merged into this issue.

Comment 7 by project member chip...@gmail.com, Mar 25, 2009

 Issue 858  has been merged into this issue.

Comment 8 by project member chip...@gmail.com, Apr 4, 2009

So, I've been unable to reproduce this lately, and am wondering if it was fixed
through something else. If anyone else can reproduce this, please let me know your
exact configuration (web server, caching server, database type, mod_python/fastcgi, etc.)

Comment 9 by project member chip...@gmail.com, Apr 4, 2009

I believe I found potential causes for this. There were ways of getting to stale
cached versions of a siteconfig, and we were definitely using these in places in our
code.

This should now be fixed in Djblets r12012.

Please comment if you still encounter this after tomorrow's (April 4, 2009) nightly.

Status: Fixed

Comment 10 by barryjco...@gmail.com, Mar 17, 2010

I'm seeing this behavior on 1.5Beta 1. Restarting apache gets the settings to take
but without that many settings are not being saved when changed in the admin UI.

Comment 11 by project member chip...@gmail.com, Mar 17, 2010

Yeah, it's definitely a bug in 1.5 beta 1, but I'd like to see if people still hit it
with the latest nightlies of both Review Board and Djblets.

► Sign in to add a comment