| Issue 726: | post-review contains trailing newlines in flienames when using Perforce. | |
| 1 person starred this issue and may be notified of changes. | Back to list |
*NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below.
,
Nov 25, 2008
See also bug 731 .
Summary: post-review contains trailing newlines in flienames when using Perforce.
Status: Confirmed Labels: -Priority-Medium Priority-Critical Milestone-Release1.0 Component-Scripts |
|
| ► Sign in to add a comment |
Pardon me for doing it again. Anyway, this is the bug report The source of the problem is caused within "_depot_to_local(self, depot_path) line 1060: return last_line.split(' ')[2] The last_line.split(' ')[2] just happens to have "\n" appending at the back. This causes the diff header cannot be read properly. The fix I did was removing the "\n" at in the last_line.split(' ')[2] before returning the string: # XXX: This breaks on filenames with spaces filename = last_line.split(' ')[2] filename = filename.replace('\n', '') return filename Again, terribly sorry about the mistake I made