What steps will reproduce the problem?
1. Add a binary to a p4 changeset
2. post-review that changeset


What is the expected output? What do you see instead?
I expected post-review to complete successfully with a link to a
reviewboard diff, but instead get this:

Traceback (most recent call last):
  File "/build/trees/bin/reviewboard/post-review", line 452, in <module>
    main()
  File "/build/trees/bin/reviewboard/post-review", line 448, in main
    tempt_fate(changenum, repository_path, client_root)
  File "/build/trees/bin/reviewboard/post-review", line 389, in tempt_fate
    upload_diff(review_request, changenum)
  File "/build/trees/bin/reviewboard/post-review", line 366, in upload_diff
    diff_content = generate_diff(changenum)
  File "/build/trees/bin/reviewboard/post-review", line 346, in generate_diff
    m = re.search(r'(\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d)', dl[1])
IndexError: list index out of range


What operating system are you using? What browser?
Linux/Gentoo 2007.0.


Please provide any additional information below.
This error happened consistently when I tried to add the p4 binary itself
to a changeset that already included two other text files.  When I created
a new test changeset with just the p4 binary by itself, post-review
completed successfully but the diff showed a lot of gibberish instead of
perhaps just listing the file name and the fact that it was a binary.  When
I added the GNU 'ls' binary to this changeset (so the changeset included
the p4 binary and the ls binary) then the same error (listed above) occured
again and post-review did not complete successfully.