| Issue 1569: | Code review linebreaks are not preserved in all views (i.e. mail) | |
| 2 people starred this issue and may be notified of changes. | Back to list |
*NOTE: Do not post confidential information in this bug report.* What version are you running? 1.5 Beta What's the URL of the page containing the problem? What steps will reproduce the problem? 1.Create a review 2.Range select some lines in the diff-view 3.enter some sort of list into the popup with linebreaks What is the expected output? What do you see instead? line breaks should be preserved in all views; -> the review index -> notification mails What operating system are you using? What browser? Please provide any additional information below.
Comment
1
by
project member
chip...@gmail.com,
Mar 24, 2010
Status: NeedInfo
,
Mar 25, 2010
tried to add a demo comment to http://demo.reviewboard.org/r/44/ I hope you're getting the mail for this one?
,
Mar 25, 2010
Heres a screenshot of a mail inside a webmailer (citadel.org) But i've seen the same in Outlook.
,
Apr 28, 2010
any more information needed for this?
,
Apr 28, 2010
There's a patch pending for this that will be in the next beta.
Status: PendingReview
Labels: Milestone-Release1.5 Component-EMail
,
May 6, 2010
Fixed on master (fc85106)
Status: Fixed
Owner: chipx86
,
May 26, 2010
The review description field wraps long lines in the browser => I'm used to just
typing and having the text wrapped.
In the sent out emails, the description is not wrapped (at least on my lotus notes
web client), causing very wide emails. My html/css has gone a bit rusty, but telling
the pre's to break if necessary seems to do the trick. I've added the following to
email_base.html:
<header>
<style type="text/css">
pre {
overflow-x: auto; /* Use horizontal scroller if needed; for Firefox 2, not
needed in Firefox 3 */
white-space: pre-wrap; /* css-3 */
white-space: -moz-pre-wrap !important; /* Mozilla, since 1999 */
white-space: -pre-wrap; /* Opera 4-6 */
white-space: -o-pre-wrap; /* Opera 7 */
/* width: 99%; */
word-wrap: break-word; /* Internet Explorer 5.5+ */
}
</style>
</header>
The css is from here:
http://www.longren.org/2006/09/27/wrapping-text-inside-pre-tags/. There might be a
better way of achieving the same ...
,
May 27, 2010
Fixed on master (5344e92) |
|
| ► Sign in to add a comment |
