My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 1500: "xx lines hidden [Expand]" link stopped working
10 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Feb 2010


Sign in to add a comment
 
Reported by jahun...@nvidia.com, Feb 16, 2010
*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.5 beta 2, dev builds 2/16 (issue also seen in 2/10)

What's the URL of the page containing the problem?
Issue can be seen on: 
http://reviews.reviewboard.org/r/1410/diff/#index_header

What steps will reproduce the problem?
> On above link, click on "124 lines hidden [Expand]"

What is the expected output? What do you see instead?
> Expect to see lines of code expanded. E.g. on above link, expect last 
hidden 124 lines to be expanded

Instead, the "Loading" icon goes away, and the screen remains as is.

What operating system are you using? What browser?
Verified on XP and Windows 7. Verified on IE 7, IE 8, and Firefox.


Comment 1 by project member trowb...@gmail.com, Feb 16, 2010
Are there any javascript errors or errors in the server log?
Status: NeedInfo
Labels: Component-DiffViewer
Comment 2 by sombr...@gmail.com, Feb 17, 2010
The problem appears to be that the commit 
http://github.com/chipx86/reviewboard/commit/7ef6e623398bb198c7b2f6cf3dc1de1673989ed6 
changed "tbody.collapsed" to "tbody.diff-header" in diff_file_fragment.html, but the 
JS code in diffviewer.js is still looking for "tbody.collapsed": 
http://github.com/chipx86/reviewboard/blob/master/reviewboard/htdocs/media/rb/js/diffv
iewer.js#L971
Comment 3 by project member trowb...@gmail.com, Feb 20, 2010
 Issue 1504  has been merged into this issue.
Comment 4 by project member trowb...@gmail.com, Feb 21, 2010
(No comment was entered for this change.)
Status: Fixed
Comment 5 by project member chip...@gmail.com, Feb 24, 2010
 Issue 1512  has been merged into this issue.
Comment 6 by project member trowb...@gmail.com, Mar 3, 2010
 Issue 1525  has been merged into this issue.
Comment 7 by project member chip...@gmail.com, Mar 18, 2010
 Issue 1558  has been merged into this issue.
Comment 8 by project member trowb...@gmail.com, Apr 8, 2010
 Issue 1584  has been merged into this issue.
Comment 9 by project member trowb...@gmail.com, Apr 13, 2010
 Issue 1619  has been merged into this issue.
Comment 10 by project member trowb...@gmail.com, May 18, 2010
 Issue 1654  has been merged into this issue.
Sign in to add a comment

Powered by Google Project Hosting