My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 1393: uploading diff fails for bzr when containing changes to a renamed file
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  Nov 2009
Type-Defect
Priority-Medium
Component-SCMTools
Milestone-Release1.0.x


Sign in to add a comment
 
Reported by kroepke, Nov 11, 2009
What version are you running?

1.0.5.1 and master

What's the URL of the page containing the problem?

N/A

What steps will reproduce the problem?
Unable to reproduce with a simple bzr branch. Working on that.
However, debugging shows that fileid is None in bzr.py.
Since bzr's fileid is created when the file is added and retained when renaming or moving files, 
the change proposed in http://reviews.reviewboard.org/r/1209/ is safe.

What is the expected output? What do you see instead?
Uploading a diff that contains changes to renamed files (all of them actually) fails with an 
SCMError exception.
Uploading should work, since the file is present, just renamed.

What operating system are you using? What browser?
Irrelevant, happens all the time.

Please provide any additional information below.
http://reviews.reviewboard.org/r/1209/ contains the proposed patch for this (works for both 
master and release-1.0.5.1).
Comment 1 by chipx86, Nov 12, 2009
Fixed on release-1.0.x and master (r7eb6cec).
Status: Fixed
Owner: chipx86
Labels: Component-SCMTools Milestone-Release1.0.x
Sign in to add a comment

Powered by Google Project Hosting