My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 1353: Change selection frame sticks to screen position when expanding unchanged lines
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chip...@gmail.com
Closed:  Oct 2009


Sign in to add a comment
 
Reported by OliverCG...@gmail.com, Oct 9, 2009
*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.0.4

What's the URL of the page containing the problem?
internal system: view diffs 

What steps will reproduce the problem?
1. Find a review request with collapsed lines above the first diff.
2. Go to "View Diff"
3. Select the first diff by clicking on it; a rectangular frame will appear
around it.
4. Expand collapsed text above the change.

What is the expected output? What do you see instead?

I would expect that the frame indicating the selected diff moves down the
page with the diff. Instead the frame stays on the screen position where
the diff was before expanding the hidden lines.

What operating system are you using? What browser?
OS: Windows XP
Browser: Firefox 3.5.3

Please provide any additional information below.
I just checked the issue with Internet Explorer 7.0.5730.13, and there it
does not occur: instead the frame moved with the selected diff as expected.

stickyframe1.png
46.2 KB   View   Download
stickyframe2.png
52.1 KB   View   Download
stickyframe3.png
53.8 KB   View   Download
Comment 1 by project member chip...@gmail.com, Oct 13, 2009
Fixed on master and release-1.0.x (rddfc9bd)
Status: Fixed
Owner: chipx86
Labels: Component-DiffViewer Milestone-Release1.0.x
Sign in to add a comment

Powered by Google Project Hosting