Issue 1267 - reviewboard - AD group selection fails when OU contains whitespace - Web-based code review tool

Issue 1267:	AD group selection fails when OU contains whitespace
	2 people starred this issue and may be notified of changes.	Back to list

Status:	Incomplete
Owner:	----
Closed:	Nov 2009
Type-Defect Priority-Medium Component-Accounts

Reported by nikolai....@gmail.com, Aug 7, 2009

*NOTE: Do not post confidential information in this bug report.*

What version are you running?

1.0.1

What's the URL of the page containing the problem?

Login page

What steps will reproduce the problem?
1. Have a stupid AD with some Groups where an OU contains a space
2. Be a user in that group
3. Try to login

What is the expected output? What do you see instead?
Everything should work fine, instead there is a "Wrong password" notice and  
"Bad search filter" message from AD.

This obviously requires changing the line 
"group_data = self.search_ad(con, 
'(&(objectClass=group)(saMAccountName=%s))' % group)"

in backends.py / get_member_of, but I'm not familiar with LDAP query 
syntax...

Comment 1 by project member trowb...@gmail.com, Sep 2, 2009

I just read through RFC 4515 and it looks like group names with spaces should be fine
in a filter spec like that.

Can you try adding double-quotes "" around the %s and test it?

'(&(objectClass=group)(saMAccountName="%s"))' % group

Status: NeedInfo

Comment 2 by project member trowb...@gmail.com, Sep 23, 2009

(No comment was entered for this change.)

Labels: Component-Accounts

Comment 3 by project member trowb...@gmail.com, Nov 27, 2009

(No comment was entered for this change.)

Status: Incomplete

► Sign in to add a comment