My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 1200: ship-it counter doesn't work as expected (always zero) [fix inside]
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Sep 2009


Sign in to add a comment
 
Reported by marc....@gmail.com, Jul 2, 2009
*NOTE: Do not post confidential information in this bug report.*

What version are you running?
reviewboard v1.0

What's the URL of the page containing the problem?
reviews.review-board.org/r/

What steps will reproduce the problem?
1. review a review-request and ask to 'ship-it' the code
2. refresh the dashboard => the ship-it has not been updated

What is the expected output? What do you see instead?
The ship-it column should have been increased

What operating system are you using? What browser?
os : n/a
database: mysql 5.1.30
django: 1.0.2

Please provide any additional information below.
as adviced in the django documentation 
(http://docs.djangoproject.com/en/dev/topics/db/sql/) the new increment_ship_it 
method from reviews/models.py should commit the database update.
adding *transaction.commit_unless_managed()* just after the *cursor.execute(...)* 
has solved this issue on my server.
Comment 1 by onkarshinde@gmail.com, Jul 31, 2009
I believe this is similar to the problem we are seeing. Apparently on our
installation the shipit count does not get incremented at all, no matter the status
of review request (pending or submitted).
Comment 2 by project member chip...@gmail.com, Sep 2, 2009
Can you please supply a patch to http://reviews.review-board.org/ ?
Status: Confirmed
Labels: Milestone-Release1.0.x Component-Reviews
Comment 3 by marc....@gmail.com, Sep 3, 2009
Hi,

   submitted here: http://reviews.review-board.org/r/1021/

Best Regards,

Marc Bee
Comment 4 by project member trowb...@gmail.com, Sep 3, 2009
Committed to release-1.0.x and master. Thanks!
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting