My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 1180: cvs.exe is never found on windows and it raises ImportError at /r/1/
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  Jul 2009
Type-Defect
Priority-Critical
Milestone-Release1.0.x


Sign in to add a comment
 
Reported by marc....@gmail.com, Jun 22, 2009
*NOTE: Do not post confidential information in this bug report.*

What version are you running?
reviewboard v1.0

What's the URL of the page containing the problem?
http://any-reviewboard-server/r/new

What steps will reproduce the problem?
1. create a new review request with a cvs repository

What is the expected output? What do you see instead?
the expected page (at least one input box to give a file)

What operating system are you using? What browser?
any browser - any windows system

Please provide any additional information below.
could be easily fixed by replacing the code below:
http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/scmtoo
ls/cvs.py, line 138
replace os.environ.get('IFS', ':') by os.pathsep

explanation:
it's quite uncommon to have such variable set on windows (IFS), so instead 
of putting ':', you should put ';', but from my point of view, using the 
solution given above is much much better.

Thanks for this great release!

Best Regards,

Marc Bee
Comment 1 by chipx86, Jun 22, 2009
We'll get this fixed for a point release.
Owner: trowbrds
Labels: -Priority-Medium Priority-Critical Milestone-Release1.0.1
Comment 2 by chipx86, Jul 16, 2009
(No comment was entered for this change.)
Labels: -Milestone-Release1.0.1 Milestone-Release1.0.x
Comment 3 by chipx86, Jul 16, 2009
(No comment was entered for this change.)
Owner: chipx86
Comment 4 by chipx86, Jul 18, 2009
Fixed in r2042
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting