My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 1110: Review board installation doesn't create windows-friendly entries in Scripts
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  May 2009
Type-Enhancement
Priority-Medium
Milestone-Release1.0
OpSys-Windows


Sign in to add a comment
 
Reported by alecmunro, May 07, 2009
*NOTE: If you have a patch, please submit it to http://reviews.review-
board.org/


What version are you running?
1.0RC1


What's the URL of the page this enhancement relates to, if any?


Describe the enhancement and the motivation for it.

When installing using easy_install, postreview and rb-site are created in 
the python Scripts folder. These are formatted as unix shell scripts, so 
they are much good on Windows. The creation of a simple .bat file that 
proxies them seems to work fine.



What operating system are you using? What browser?
Windows 2003 Server

Please provide any additional information below.

Comment 1 by javier.ortiz.78, May 07, 2009
Do you have suce file? I would love to have it. I think this is related to:

http://code.google.com/p/reviewboard/issues/detail?id=1082&q=rb-site%
20windows&sort=milestone&colspec=ID%20Type%20Status%20Priority%20Component%20Owner%
20Summary%20Milestone


Comment 2 by alecmunro, May 07, 2009
That seems related. I've attached my bat files (which are specific to Python25, so if 
you are using something else, you may have to edit them).

Also, they only accept up to 9 arguments, as I'm not sure what the escape sequence 
would be beyond that.
post-review.bat
83 bytes   Download
rb-site.bat
77 bytes   Download
Comment 3 by chipx86, May 08, 2009
I'll have this fixed in RC3. I believe I now know what's needed to generate .exe
files for rb-site, but it will need some testing.
Status: Confirmed
Owner: chipx86
Labels: Milestone-Release1.0 OpSys-Windows
Comment 4 by chipx86, May 08, 2009
Fixed in r1967. A rb-site.exe will be provided in RC3, or in tonight's nightly.
Status: Fixed
Comment 5 by javier.ortiz.78, May 08, 2009
1084 is a duplicate of this issue.
Sign in to add a comment

Powered by Google Project Hosting