My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 1071: Review Board does not handle files with ^M characters at end of line.
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  May 2009
Type-Defect
Priority-High
Milestone-Release1.0
Component-DiffViewer
Component-RBTools


Sign in to add a comment
 
Reported by raghu.kb, Apr 21, 2009
Review Board does not handle files with ^M characters at end of line.

What steps will reproduce the problem?
1. The setup is a review board server using a perforce repository
2. Create a changelist that contains at least one file with ^M characters
at end of line - i.e. \r\r\n patterns at end of line.
3. Use post-review to send it to review board.
4. Attempt to view the diff. You get a traceback.

What is the expected output? What do you see instead?
There should not be any stack trace, instead I get an error:
The patch to '%s' didn't apply cleanly. The temporary files have been left
in '%s' for debugging purposes.

I have a patch for this submitted for review.
Comment 1 by chipx86, May 28, 2009
Committed as r1988.
Status: Fixed
Owner: chipx86
Labels: -Priority-Medium Priority-High Milestone-Release1.0 Component-DiffViewer Component-RBTools
Sign in to add a comment

Powered by Google Project Hosting