My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 1056: "Review" button shouldn't leave the diff view
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  Apr 2009
Type-Defect
Priority-Medium
Milestone-Release1.0
Usability
Component-Reviews
EasyFix


Sign in to add a comment
 
Reported by jamesdlin, Apr 16, 2009
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. View the diff to some review request.
2. Click the "Review" button (because as I'm reading the diff, I want to
make some general comment about, say, the design).
3. Click the "Save" button.


What is the expected output? What do you see instead?
Reviewboard leaves the diff view and throws me to the review request's main
page.  Consequently, I've now lost my place in the diff.  IMO, this should
happen only when clicking "Publish", not "Save".


What operating system are you using? What browser?
Firefox 3.0.8 on Windows XP x64 SP2.


Please provide any additional information below.

Comment 1 by chipx86, Apr 19, 2009
(No comment was entered for this change.)
Status: Confirmed
Owner: chipx86
Labels: Milestone-Release1.0 Usability Component-Reviews EasyFix
Comment 2 by chipx86, Apr 19, 2009
Fixed in r1914.
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting