| Issue 1050: | Screenshot Comment location issue with Chrome | |
| 2 people starred this issue and may be notified of changes. | Back to list |
*NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? http://reviewboard.site.com/r/revision-number/s/screenshot-number/ What steps will reproduce the problem? 1. In Chrome, create a screenshot comment 2. Save your review 3. Look at the comment in any other browser, or in a different window size of chrome What is the expected output? What do you see instead? The screenshot location should be based on the image itself, currently it looks like the location is purely based on where the box was in the browser window itself when it was created - thus those viewing the screenshot comment will not see it in the correct location. In addition, if you create a screenshot comment in, say, FireFox and then look at it in chrome, you'll notice that the same problem occurs (the comment isn't where it is supposed to be) What operating system are you using? What browser? WinXP - Chrome - This appears to be a problem with Chrome and ReviewBoard. Please provide any additional information below. Djblets-0.5beta2.dev_20090415-py2.4.egg ReviewBoard-1.0beta3.dev_20090415-py2.4.egg
,
Apr 19, 2009
The problem looks like it is in the .position function found in jquery - a file that's extremely difficult to look at or tweak... Looks like it is fixed in jquery 1.3.3 (which isn't released yet) http://dev.jquery.com/ticket/4263
,
Apr 20, 2009
We'll take the fix if jQuery 1.3.3 comes out before our 1.0, and doesn't cause any serious regressions like 1.3.2 did. We may end up postponing this to a 1.0.x release, if we need to.
,
Apr 20, 2009
Yea, i spoke too soon - the change I linked to fixes something else (i tested it later last night). If I get time later this week I'll look into making a patch for jquery as well as for RB's jquery1.3.2mini
,
Apr 22, 2009
That would be nice, but I'm not going to hold my breath that we'll fix this without regressions right now. Going to push back to 1.5. If you do fix it, let us know and we'll consider the fix for 1.0.
Labels: -Milestone-Release1.0 Milestone-Release1.5
,
Jun 3, 2009
I have the same problem with Safari 4.
,
Sep 16, 2009
(No comment was entered for this change.)
Labels: -Milestone-Release1.5 Milestone-Release1.0.x
,
Oct 9, 2009
Fixed in 1.0.4.
Status: Fixed
Owner: chipx86 |
|
| ► Sign in to add a comment |
Labels: -Priority-Medium Priority-Low Milestone-Release1.0 Component-Screenshots Browser