| Issue 1036: | Interdiff of files removed from a change cause weird things | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
*NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? http://reviews.review-board.org/r/753/diff/2-3/#index_header What steps will reproduce the problem? 1. Post a review of a file and publish 2. Update the review with a new diff that adds a file and take out the file from step 1 (revert your change) What is the expected output? What do you see instead? In the interdiff, the "Files Changed" listing is incorrect. Looking at review 753 you can see in the attached file (real-review.png): - rbtools/scripts/post-review is the "new" file, but it has a little loading icon that never goes away. - contrib/tools/post-review shows a bunch of changes. I think this is more of a commentary on issue 1011 where it should probably just say "changes reverted". I also made a test review (test-review.png) using Perforce where you can see slightly different behavior. I added a file TEST1 and published. Then I reverted that add and added a file TEST2 in the same change, and posted it: - Again, one of the reviews in the "files changed" has a busy icon that doesn't go away. - Unlike the other review, this one shows TEST2 in the "files changed" twice. The actual diff contents look correct to me, the main problem is just the "files changed" listing. What operating system are you using? What browser? Any. Please provide any additional information below. |
||||||||||||||||
,
Apr 21, 2009
(No comment was entered for this change.)
Status: Confirmed
Labels: Milestone-Release1.0 Interdiffs Component-DiffViewer |
|||||||||||||||||
,
Apr 21, 2009
(No comment was entered for this change.)
Owner: chipx86
|
|||||||||||||||||
,
Apr 21, 2009
I just couldn't sleep until I fixed this. The weirdness should now be fixed in r1036. It was due to cache issues when switching between normal diffs and interdiffs for added files.
Status: Fixed
|
|||||||||||||||||
,
Apr 21, 2009
Er, r1923. Bed time. |
|||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||