Issue 1032 - reviewboard - Diff currently unavailable when viewing diffs of diffs

Status:	Fixed
Owner:	chipx86
Closed:	May 2009
Type-Defect
Priority-Medium
Milestone-Release1.0
Interdiffs
Component-DiffViewer

Sign in to add a comment

Reported by mw.triad, Apr 11, 2009

What steps will reproduce the problem?
1. Post a review request with changes to multiple files
2. Change some, but not all of said files
3. Upload an updated diff
4. View the changes between the first and second set of diffs

What is the expected output?
Files that have not changed are either clearly marked as such or omitted
from the output.

What do you see instead?
"Diff currently unavailable" error for files that did not change between
the two diff sets.

What operating system are you using? What browser?
RB 1.0b2 on Linux. Using Firefox.

Comment 1 by sebastien.saunier, Apr 11, 2009

I have the same issue.

Comment 2 by chipx86, Apr 23, 2009

This shouldn't be happening anymore. Can you try a nightly and see if you're still
hitting this? It's important for us to know soon for beta 1.

Can you get a very simple repro case? Ideally post something to demo.review-board.org
that I can test against.

Status: NeedInfo
Owner: chipx86
Labels: Milestone-Release1.0 Interdiffs Component-DiffViewer

Comment 3 by chipx86, Apr 25, 2009

Assuming it's fixed. Make sure to also clear your server cache. Please reopen if this
still happens.

Status: Fixed

Comment 4 by dbyl...@musiciansfriend.com, May 06, 2009

this is happening for me with ReviewBoard-1.0rc2.dev_20090506-py2.4.egg

server running on CentOS 5 with mod_python under apache 2.2

client opensuse 10.2 running Firefox 2.0.0.17

Comment 5 by chipx86, May 06, 2009

Can you provide a set of diffs that work as a repro case for this?

Status: NeedInfo

Comment 6 by dbyl...@musiciansfriend.com, May 07, 2009

The error appears on http://subversion-test/reviews/r/14/diff/1-2/#index_header

NOTE: 
Diff 1 changes both file1.txt and file2.txt
Diff 2 changes file1.txt but does not change file2.txt (relative to Diff 1)

bug-1.patch
1.0 KB View Download

bug-2.patch
1.2 KB View Download

Comment 7 by chipx86, May 07, 2009

Your patches don't cause this to repro for me. It works perfectly fine here.

Can you upload something to demo.review-board.org against the Review Board codebase
that demonstrates this?

Comment 8 by dbyl...@musiciansfriend.com, May 08, 2009

http://demo.review-board.org/r/1767/diff/1-2/#index_header

Note that the interdiff for file2.txt shows

Diff currently unavailable.
Error: Internal error. Unable to locate file record for filediff 1975

I would expect either no frame displayed for file2.txt (this would be my preference),
or a message like "no changes made in file2.txt", or a blank frame

Comment 9 by chipx86, May 09, 2009

The reason for this is that we filter out unchanged diffs when displaying interdiffs,
but only when loading fragments. So up-front, we think we have this one, but then we
don't return anything when we load the fragment since it didn't change, hence the
error about not finding the fragment.

Comment 10 by chipx86, May 09, 2009

Fixed in r1968.

Status: Fixed

Issue 1032:	Diff currently unavailable when viewing diffs of diffs
	4 people starred this issue and may be notified of changes.	Back to list