My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 1031: Keyboard shortcut only compatible with QWERTY keyboard
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  Apr 2009
Type-Defect
Priority-Low
Usability
EasyFix
Keyboard
Milestone-Release1.0
Component-DiffViewer


Sign in to add a comment
 
Reported by sebastien.saunier, Apr 10, 2009
Hello,

Our french developper team is going to use RB, but the shorcuts [ and ] for 
privous and next comments are not working on a FR keyboard (I assume it's 
because "[" = "AltGr + (" and "]" = "AltGr + )" on a french keyboard).

I added in /var/www/reviewboard/htdocs/media/rb/js/diffviewer.js the keys 
"x" and "c" for previous and next comment, but I have two problem :
- What will happen when I will have to do a easy_install -U ReviewBoard 
followed by a rb-site upgrade ? Will my change in the code overwritten ?
- I guess it would be nice to allow a personalisation of these shortcuts in 
the admin dashboard.

Thank you very much for the good work !
Comment 1 by chipx86, Apr 19, 2009
We can make that change in Review Board.
Status: Confirmed
Labels: -Priority-Medium Priority-Low Usability EasyFix Keyboard Milestone-Release1.0 Component-DiffViewer
Comment 2 by chipx86, Apr 19, 2009
Added "x" and "c" keyboard shortcuts. Committed in r1909.
Status: Fixed
Owner: chipx86
Comment 3 by sebastien.saunier, Apr 19, 2009
Great, thank you very much !
Sign in to add a comment

Powered by Google Project Hosting