Issue 1028 - reviewboard - diffviewer does not show all comments

Issue 1028:	diffviewer does not show all comments
	3 people starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	chipx86
Closed:	Apr 2009
Type-Defect
Priority-Critical
Milestone-Release1.0
Component-DiffViewer

Reported by ksuszka, Apr 07, 2009

There is a serious bug in findLineNumRow/addCommentFlags java script 
functions in ReviewBoard Beta 2 which causes some comments not to appear 
on diff viewer page. (Almost 30% of all comments is not visible on my 
reviewboard web site)

addCommentFlags calls findLineNumRow function and passes LINE numbers as 
second and third argument, but findLineNumRow treats second and thirds 
argument as ROW numbers. As the result, findLineNumRow function narrows 
the area of search to much.

Comment 1 by ksuszka, Apr 07, 2009

I've just recreated the issue on review board demo page. You can see it:
http://demo.review-board.org/r/1621/

There are two comments, click the second comment.

Comment 2 by chipx86, Apr 07, 2009

(No comment was entered for this change.)

Status: Confirmed
Labels: -Priority-Medium Priority-Critical Milestone-Release1.0 Component-DiffViewer

Comment 3 by sebastien.saunier, Apr 10, 2009

Right, and on http://demo.review-board.org/r/1621/, if you click on "16 lines hidden 
[Expand]" below, the second comment does appear.

Comment 4 by chipx86, Apr 17, 2009

Fixed in r1906.

Status: Fixed
Owner: chipx86

Comment 5 by chipx86, Apr 21, 2009

 Issue 1029  has been merged into this issue.

► Sign in to add a comment