My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 1013: Comment Box does not show in screenshot page
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  Mar 2009
Type-Defect
Priority-Medium
Milestone-Release1.0
Component-Screenshots


Sign in to add a comment
 
Reported by bacchusf, Mar 31, 2009
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
http://demo.review-board.org/r/1608/s/16/

What steps will reproduce the problem?
1. draw a box in the picture
2. click the green box

What is the expected output? What do you see instead?
A comment box should pop up.
Instead, getting this message:
--------------
Error: commentDetail.one("close", function () {activeCommentBlock =
commentBlock;commentDetail.setCommentBlock(commentBlock).positionToSide(commentBlock.flag,
{side: "b", fitOnScreen: true});commentDetail.open();}).close is not a function
Source File: http://demo.review-board.org/media/rb/js/screenshots.js?1238392124
Line: 427
--------------

What operating system are you using? What browser?
installed on Ubuntu 8.04 with apache mod_python
tested on mac safari, firefox, linux firefox

Please provide any additional information below.

The same problem is reported as  issue 1001  and fixed by beta2.

        commentDetail
            .one("close", function() {
                activeCommentBlock = commentBlock;
                commentDetail
                    .setCommentBlock(commentBlock)
                    .positionToSide(commentBlock.flag, {
                        side: 'b',
                        fitOnScreen: true
                    });
                commentDetail.open();
            })
            .close()
Comment 1 by chipx86, Mar 31, 2009
This is fixed in r1892.

You can upgrade to tonight's nightly in a couple hours and this will be fixed.
Status: Fixed
Owner: chipx86
Labels: Milestone-Release1.0 Component-Screenshots
Comment 2 by chipx86, Apr 22, 2009
 Issue 1079  has been merged into this issue.
Sign in to add a comment

Powered by Google Project Hosting