| Issue 1001: | Adding comment to review fails with javascript error | |
| 1 person starred this issue and may be notified of changes. | Back to list |
*NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? http://reviews.review-board.org/r/589/diff/#index_header What steps will reproduce the problem? 1. Click on any line number to add a new comment 2. The green comment flag appears at the beginning of the line, however no dialog ever appeared to enter the comment. 3. Looking at javasript error console I see the following output: "Error: gCommentDlg.one("close", function () {gCommentDlg.setCommentBlock(self).css({left: $(document).scrollLeft() + ($(window).width() - gCommentDlg.width()) / 2, top: self.endRow.offset().top + self.endRow.height()}).open(self.el);}).close is not a function Source File: http://reviews.review-board.org/media/rb/js/diffviewer.js? 1238313533 Line: 361" What is the expected output? What do you see instead? Expected output is to display the comments dialog as described in the documentation (http://review- board.org/docs/manual/dev/users/reviews/reviewing-diffs/). What operating system are you using? What browser? Tested on Win XP SP3, FF 3, Safari 3 and Chrome.
Comment
1
by
bacch...@gmail.com,
Mar 29, 2009
,
Mar 29, 2009
Fixed in r1886. Doing a release soon.
Status: Fixed
Owner: chipx86 Labels: -Priority-Medium Priority-Critical Milestone-Release1.0 Component-DiffViewer |
|
| ► Sign in to add a comment |