My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 100: Allow for reviews based on an existing committed revision in the web UI
16 people starred this issue and may be notified of changes. Back to list
Status:  Confirmed
Owner:  ----
Type-Enhancement
Priority-High
Component-Reviews
Milestone-Release1.6


Sign in to add a comment
 
Reported by davevanderson, Jun 06, 2007
What's the URL of the page containing the problem?
http://demo.review-board.org/r/new/

1. I'd like to be able to request a review of already checked-in code by
simply selecting a "{revision_number} - {revision_comment.substring}" from
a drop-down box based on the selected repository.

Comment 1 by trowbrds, Jun 06, 2007
(No comment was entered for this change.)
Summary: Allow for reviews based on an existing committed revision
Labels: -Type-Defect Type-Enhancement
Comment 2 by trowbrds, Jun 13, 2007
(No comment was entered for this change.)
Labels: Component-Reviews
Comment 3 by mgedmin, Jul 30, 2007
I second the wish for reviewing already committed code.  It would be especially
useful for reviewing code on other branches prior to merging them.

I'm not sure about a drop-down box.  The Zope 3 subversion repository already has
over 70 thousand revisions, that's a bit much for a drop-down.
Comment 4 by John.L.Huddleston, Aug 17, 2007
As an alternative to selecting revisions from a list would you be open to using two
integer fields to choose a range of revisions for a given repository?

For background: we have one development and one production server at work so we
generally check-in changes on dev and review them there before making them live.  We
will sometimes consider several minor revisions as a common change set so we would
prefer to diff a range as opposed to stepping through each minor revision.
Comment 5 by dabukun, Aug 30, 2007
I agree with John; this would be extremely useful.  We have a similar environment
here and it would be great to be able to auto-generate diffs based on committed
revisions instead of producing the diffs manually.
Comment 6 by philippe.normand, Oct 01, 2007
Hey,

I patched post-review to add a new option: --revision-range
No UI integration, but post-review seems quite easy to use ;)
http://reviews.review-board.org/r/162/
Comment 7 by jtradke, Oct 22, 2007
Any chance of this getting a bump in priority?  Right now we're evaluating several
different code review tools and this feature would make RB my fave.
Comment 8 by matt.fowles, Oct 25, 2007
I agree that this would be extremely useful, especially if it allowed specify things as:

branch1 revision#
branch2 revision#
Comment 9 by trowbrds, Dec 24, 2007
Does the post-review implementation work for people?
Comment 10 by phil.crosby, Feb 21, 2008
Other non-svn clients need support for this. Also, this should be doable from the web UI.
Comment 11 by chipx86, Feb 24, 2008
We're trying to keep from adding new features until 1.0 goes out. I have some ideas
for this in the web UI for 2.0.
Labels: Milestone-Release2.0
Comment 12 by erichuss, Jul 31, 2008
I worked on the original changes to post-review to support this for Perforce. 
However, it doesn't support ranges for Perforce.

I'm not sure if I should open a separate issue for this, but I would like to have the
ability to post a review for an entire, existing file (range #0 to #head in perforce
parlance).  For example, if there is a file in the repository and maybe it's been
around for a few years and has had many changes to it and has gotten a little crusty,
I would really like to be able to post the entire file up for review (independent of
a changeset or diff).  It should show up as-if it were an "added" file (green, single
column display).  Perhaps reviewboard could even leverage the interdiff magic and
show all committed revisions of that file.
Comment 13 by chipx86, Aug 04, 2008
(No comment was entered for this change.)
Summary: Allow for reviews based on an existing committed revision in the web UI
Labels: -Priority-Medium -Milestone-Release2.0 Priority-High Milestone-Release1.5
Comment 14 by trowbrds, Sep 28, 2008
(No comment was entered for this change.)
Status: Confirmed
Comment 15 by nithinsu...@gmail.com, May 24, 2009
We have a similar requirement. We would like to be able to create a review of checked
in files but giving a list of files, and a date range or label range in perforce.

Looking forward to this feature.
Comment 16 by mar...@maine.rr.com, Jul 02, 2009
I have a request from our team for something similar to this.  We'd like to be able
to have reviewers self-select committed revisions for review and feedback. 
Essentially, a lead reviewer would browse a range of svn checkins (the previous
day's, for example) from a repository or a selected subtree of a repository, be able
to view the diff and review the code (or publish the diff for wider review) on the spot.
Comment 17 by cybrocop, Jul 29, 2009
I would like to also comment that this feature would be VERY useful for us.

The post-review process is cumbersome and requires all developers to have python
installed on their machines and another script to maintain/update. 

Instead of drop down boxes the user should simply type-in the revision number. This
is both simple to implement and more useful if there are too many revisions.
Comment 18 by Stefan.B...@gmx.net, Aug 28, 2009
+1 vote for this enhancement.

A simple edit field to type in rev numbers should be suffficient.
Drop down boxes would be nice to have but should really be useable with big
repositories storing thousands of revisions.
Comment 19 by chipx86, Dec 20, 2009
(No comment was entered for this change.)
Labels: Milestone-Release1.6
Sign in to add a comment

Hosted by Google Code