New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failures in tests with latest proj v4.9.1 #6
Comments
The tests that are failing are the ones that require epsg, which are a commonly used as a shorthand for long projection string. I would say that this is problematic. |
thanks for your comment. Meanwhile I moved to release 2.0.0 for pyproj, and the test results for this one seem much better. All tests pass for python2 and only 5 out of 103 tests fail for python3. See: |
whoops, sorry, mixing two projects here. Version 2.0.0 refers to pygrib. Ofcourse pyproj is still at 1.9.4 |
pyproj still is at 54 passed and 19 failed, both for python2 and python3, see: |
OK, latest github version looks good. All 73 tests pass both for python2 and python3. Closing this issues. |
just for reference, the few failures reported by mistake above on pygrib v2.0.0, are also solved for the latest github version. Here both python2 and python3 versions give me 105 passed tests. |
Hmm.. If the lastest github version passes all the test. Perhaps there needs to be a new release. Version 1.9.5? |
yes, that would be nice. I noticed there are more reasons to go for a new release, see the discussion in issue #33 on Travis, so if that one is resolved it seems a good idea to me. |
A final note on this issue. Afteral it seems the large number of fails was due to my own mistake in the building of the rpm package for pyproj. In Fedora pyproj depends on proj but also on proj-nad and proj-epsg, and I had included these as requirements. However, they are also needed when running the unit tests during the rpm build process, and in this case they should be added as BuildRequires in the spec file as well. After adding this the majority of tests run fine. I'll mention the remaining failures (related to the hammer projection) in another issue. |
Hi,
I just tried to build pyproj for Fedora Rawhide, using the brand new proj-4.9.1 release and switched on the tests defined in pyproj/init.py.
I noticed that a fair number of them fail with this new proj version. Out of 73 tests the overall score was 54 passed and 19 failed (and it does not depend on the architecture used by the build.
Could you please take a look and let me know if this indicates real problems, or if this can be safely ignored for now?
The testresults are in these logfiles:
https://kojipkgs.fedoraproject.org//work/tasks/889/9210889/build.log
https://kojipkgs.fedoraproject.org//work/tasks/888/9210888/build.log
https://kojipkgs.fedoraproject.org//work/tasks/887/9210887/build.log
The text was updated successfully, but these errors were encountered: