Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyftpdlib should handle the case when accept() returns None instead of a socket #91

Closed
giampaolo opened this issue May 28, 2014 · 6 comments
Closed

pyftpdlib should handle the case when accept() returns None instead of a socket #91

giampaolo opened this issue May 28, 2014 · 6 comments
Labels
bug Component-Library imported imported from old googlecode site and very likely outdated

Comments

@giampaolo
Copy link
Owner

From billiej...@gmail.com on November 17, 2008 01:18:45

Sometimes when running the server under heavy loads (e.g. while serving a
lot of clients) an exception can be raised at the time the server is
accepting a new connection:

  File "C:\Python25\lib\asyncore.py", line 384, in handle_read_event
    self.handle_accept()
  File "C:\python25\lib\site-packages\pyftpdlib\ftpserver.py", line 3072,
in handle_accept
    sock_obj, addr = self.accept()
TypeError: 'NoneType' object is not iterable


This happens because for some reason, sometimes accept() returns None
instead of a socket.  The code should ignore this case.

Original issue: http://code.google.com/p/pyftpdlib/issues/detail?id=91
@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on November 16, 2008 16:33:21

Fixed in r439 .

Status: Finished

@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on November 20, 2008 12:56:33

Labels: Milestone-0.5.1

@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on January 21, 2009 10:05:51

Fixed in version 0.5.1 released on 2009-01-21.

Status: Fixed

@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on April 02, 2009 08:53:55

Labels: -OpSys-All

@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on April 04, 2009 06:42:45

Labels: Crash

@giampaolo
Copy link
Owner Author

From g.rodola on November 05, 2010 19:03:07

Added a test case which covers this but in r749 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Component-Library imported imported from old googlecode site and very likely outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@giampaolo