Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDUP command always changes to "/" #118

Closed
giampaolo opened this issue May 28, 2014 · 4 comments
Closed

CDUP command always changes to "/" #118

giampaolo opened this issue May 28, 2014 · 4 comments
Labels
bug Component-Library imported imported from old googlecode site and very likely outdated

Comments

@giampaolo
Copy link
Owner

From itasuke@gmail.com on July 28, 2009 09:33:25

What steps will reproduce the problem?  
1. start pyftpdlib
2. after login the server, move into a deep directory
3. send a CDUP command

192.168.3.3:4117 <== CWD /abc/def
192.168.3.3:4117 ==> 250 "/abc/def" is the current directory.
192.168.3.3:4117 <== CDUP
192.168.3.3:4117 ==> 250 "/" is the current directory. 

What is the expected output?  


What do you see instead?  
192.168.3.3:4117 ==> 250 "/abc" is the current directory. What version of 
pyftpdlib are you using? On what operating system? Which Python version? 
ftpserver r609 Windows vista
CPython 2.6.2 

Please provide any additional information below.  
When you send a CDUP command,
FTPHandler.found_terminator method finds the real parent directory in line
1844.
But ftp_CDUP method calls ftp_CWD method with a hard-coded path in line 2735. 

I think ftp_CDUP should call ftp_CWD like this:
self.ftp_CWD(line)

Original issue: http://code.google.com/p/pyftpdlib/issues/detail?id=118

@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on July 28, 2009 02:52:20

Thanks! Fixed as r612 .

Status: Finished
Labels: Version-0.5.1 Milestone-0.5.2

@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on August 29, 2009 10:34:03

Status: FixedInSVN

@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on September 13, 2009 13:56:15

Status: Fixed

@giampaolo
Copy link
Owner Author

From billiej...@gmail.com on September 13, 2009 14:01:52

This is now fixed and included as part of 0.5.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component-Library imported imported from old googlecode site and very likely outdated
Projects
None yet
Development

No branches or pull requests

1 participant