Original comment 1. posted by gbtami 2010-09-02

• added label: Defect

Original comment 2. posted by igor2x 2010-09-04

I did the following:

1. removed first line of "PyChess is translated into 33 languages", because this is about translators and not statistics and also every time new language is added this number should manually change in file - annoying. So just removed it.
2. I removed "translators"" word like "Arabic translators", so now it is only "Arabic"
3. Put character "" before translation language, so Arabic now becomes " Arabic" - this separates languages from translators.
4. I added myself to "Slovenian" translators. :)

Please see attached file. If you like the change then please commit this new file.

• attached TRANSLATORS

Original comment 3. posted by igor2x 2010-09-04

gbtami, I see you have made some changes to translators.py file in revision d6394f1d6e. Now I understand TRANSLATORS file is automatically generated from Launchad.

But are you sure all of translators will be listed in TRANSLATORS file if only import from Launchpad is made? What about upstream translators like me?

Also importing translators from Launchpad will import translators from older version of PyChess. Not all of that translations are available in PyChess anymore - if you look into lang directory you will see there are some languages missing from TRANSLATORS file.

Original comment 4. posted by gbtami 2010-09-04

Heh, that commit was made accidentally :) I'v just started to play with it.
Your points are correct, we have to rework this script.

Original comment 5. posted by igor2x 2010-09-11

If I understand correctly Thomas has made an update of script and now TRANSLATORS file looks updated with Launchpad now showing 50 languages. I also see that list is a merge of Launchpad and upstream PyChess translations shipped directly into Google code (like my translations). So this looks fixed.

Three more issues on this topic:

1. It looks like TRANSLATION file is not alphabetically ordered by translation languages any more, you see e.g. for Spanish:
   English (United Kingdom)
   Spanish
   Estonian
   but also whole ordering of languages is not alphabetically.
2. I also think that translator names inside individual language should be ordered alphabetically.
3. This TRANSLATOR file is not reflected in actual PyChess code in Help | About | Credits | Tranlated by tab. PyChess still has an old list. If I understand correctly PyChess is using (probably some manual import) from TRANSLATION file.

Original comment 6. posted by igor2x 2010-10-25

I have updated TRANSLATORS file with ./translators.py and commited changes: Rev: 1d4d00955c

It looks like PyChess is not reading TRANSLATORS file when PyChess is running. It looks there is some kind of import done into python code. Help | About still shows 33 languages.

Original comment 7. posted by gbtami 2010-10-25

With revision 3b7e3c9146 the About dialog is reading data from AUTHORS, ARTISTS, DOCUMENTERS and TRANSLATORS files.

Original comment 8. posted by gbtami 2010-10-26

The order issue is fixed in revision 4b6e4ca129.

• changed status to: Fixed

Original comment 9. posted by igor2x 2010-10-26

gbtami, it looks ok for 99,999% of users/languages, but for Slovenian is not correct sorting. I think the reason is because all of the users are acquired from launchpad except for me (Igor). In translators.py file there is extra string "extraTranslators" that is not sorted correctly.

Original comment 10. posted by gbtami 2010-10-26

You are right :) To solve this in the shortest way I ask you to register to lunchpad, and touch the sl translation at least once. Then we can forget the "extraTranslators" workaround.

Original comment 11. posted by igor2x 2010-10-26

gbtami, excellent idea, why having a hack for one single exception. I have created Launchpad account, made some "touch" to the sl translation.

Then I have deleted TRANSLATORS file. Deleted extraTranslators strings from translators.py file and committed the changes to revision 503b197ed9.

Original comment 12. posted by gbtami 2010-10-26

Super, thank you!