Original comment 1. posted by lobais 2010-06-03

This is in the context:

soundfilter = gtk.FileFilter()
soundfilter.add_custom(soundfilter.get_needed(),
lambda data: data[3].startswith("audio/"))

I can read now in http://www.pygtk.org/docs/pygtk/class-gtkfilefilter.html#method-
gtkfilefilter--add-custom that the four fields in the data tuple (which they call
filter_info for confusion) can be strings or None.
It doesn't say when they will be None, but I suppose it is on folders and nonfile
things. The patch will be to change

lambda data: data[3].startswith("audio/")

into

lambda data: data[3] and data[3].startswith("audio/")

I can't commit it right now though.

• changed status to: Accepted

Original comment 2. posted by thomas.spura 2010-06-06

Ok, let me know, if I can help out anyhow.

I changed it here locally and don't see any noticeable regression.

diff -r 721db5d4e091 lib/pychess/widgets/preferencesDialog.py
--- a/lib/pychess/widgets/preferencesDialog.py Tue May 11 22:33:16 2010 +0200
+++ b/lib/pychess/widgets/preferencesDialog.py Sun Jun 06 14:56:24 2010 +0200
@@ -306,7 +306,7 @@ class SoundTab:

     soundfilter = gtk.FileFilter()
     soundfilter.add\_custom(soundfilter.get\_needed(),

•                           lambda data: data[3].startswith("audio/"))
  

•                           lambda data: data[3] and data[3].startswith("audio/"))
   opendialog.add_filter(soundfilter)
   opendialog.set_filter(soundfilter)
  

Original comment 3. posted by lobais 2010-06-08

Its ok, I got my hg fixed. It should be in Head now.

Original comment 4. posted by thomas.spura 2010-06-11

Yes, this should be fixed and this, but the commit before destroyed some other parts and with now current head (1539:c37ce7c65bd9) I get a lot of warnings, posting here, to let you know (if you don't do yet).

I'd say this is fixed now.

Thanks.

##################################################################################

$ PYTHONPATH=./lib ./pychess

(pychess:4254): libglade-WARNING **: could not look up stock id '_New Game'

(pychess:4254): libglade-WARNING **: could not look up stock id '_Play Internet Chess'

(pychess:4254): libglade-WARNING **: could not look up stock id '_Load Game'

(pychess:4254): libglade-WARNING **: could not look up stock id '_Save Game'

(pychess:4254): libglade-WARNING **: could not look up stock id 'Save Game _As'

(pychess:4254): libglade-WARNING **: could not look up stock id 'Offer _Undo'

(pychess:4254): libglade-WARNING **: could not look up stock id '_Rotate Board'

(pychess:4254): libglade-WARNING **: could not look up stock id '_Fullscreen'

(pychess:4254): libglade-WARNING **: could not look up stock id 'Leave _Fullscreen'

(pychess:4254): libglade-WARNING **: could not look up stock id 'About Chess'

(pychess:4254): libglade-WARNING **: could not look up stock id 'How to play'

(pychess:4254): libglade-WARNING **: could not look up stock id 'Translate PyChess'

(pychess:4254): libglade-WARNING **: could not look up stock id 'Tip of the Day'
no stock_draw-rounded-square-unfilled icon in icon-theme-gnome
no stock_draw-rounded-square icon in icon-theme-gnome
/home/tom/programming/repositories/pychess.hg/lib/pychess/System/uistuff.py:374: GtkWarning: GtkSpinButton: setting an adjustment with non-zero page size is deprecated
self.glade = gtk.glade.XML(addDataPrefix("glade/%s" % filename))
00:11:02 Default Warning: Can't end a game that's already ended: 8 1

Original comment 5. posted by gbtami 2010-06-24

.glade files seems fixed too, so i close this.

• changed status to: Fixed

Original comment 6. posted by mattgatto 2010-08-15

issue #573 has been merged into this issue.