My favorites | Sign in
Project Home Downloads Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1235: [Patch] Use SSA/ASS rendering only for SSA subtitles
2 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Jan 2012


Sign in to add a comment
 
Project Member Reported by happy.neko, Sep 27, 2011
Right now if "ASS/SSA subtitles" box is checked PS3MS use mencoder's new "-ass" rendering mode for all subtitles including plaintext SRT. The problem is that current revision of mencoder (tested with r34118) does not honour "-ass-force-style" command line flag in that case. We still can set font colour, size and border with "-ass-color", "-ass-border-color", "-ass-font-scale" but anything else is ignored including vertical margin. And it's pretty annoying especially with 4:3 content on widescreen TV when subtitles become cropped.

The idea behind my patch is that we really don't need fancy SSA mode for rendering simple plaintext subtitles. All settings like font, size, outline and margin can be set in old plaintext mode anyway and it backed by far more stable mplayer codebase. On the other hand we can use SSA mode for SSA subtitles if user checked "Use formating for ASS/SSA subtitles" box or render them on plaintext mode otherwise. 

I also changed some corresponding GUI captions to make their meaning more clear for the user. Like "Default font settings" are now "Plaintext subtitles setting", "ASS font settings" - "Formated subtitles settings" etc. I also remove misleading "asian" form "Specify TrueType Font (for Asian languages)" because this setting change font for all subtitles of any language. See attached screenshot. 

On related subject but not covered in this patch we should correct font selection dialog behaviour because mencoder with fontconfig expects registered system font name (you can get them with fc-list command) not absolute path to ttf file. For now you can enter it by hand but if fontname contains spaces generated mencoder commandline is broken.
gui.png
18.5 KB   View   Download
Sep 27, 2011
Project Member #1 happy.neko
Sorry. Posted wrong patch.
use-ssa-rendering-only-for-ssa-subtitles.patch
8.4 KB   View   Download
Dec 21, 2011
Project Member #2 happy.neko
Updated version for trunk rev. 1010.

Other changes:
+ Support for external ASS/SSA subtitles and .mp4 video. Seems to be working fine with latest mencoder.
+ Better English and Russian translations
+ GUI improvements: disable ssa styling options (font scale, color, outline etc) when "use embedded style" is checked)
use-ssa-rendering-only-for-ssa-subtitles-r1010.patch
24.1 KB   View   Download
Dec 21, 2011
#3 ExSportCZ@gmail.com
I am not sure if I understand right but I suppose people like to see plaintext subtitles to be rendered nicely(SSA engine) instead of plaintext rendering which is not so nice. I am not sure if disabling this option at all is right direction.
Maybe for someone it is problem that not all ASS features are supported for SRT files but for others it is not problem and benefits from well rendered subs.
Then all will be satisfied after applying this mod:-)
Regards ExSport
Dec 21, 2011
Project Member #4 happy.neko
Actually plaintext rendering is not bad at all: you can customize font, size, margin etc. Everything except subs color, it is always white. And the best thing: it actually works :)

On the other hand SSA rendering silently ignores styling options for SRT subtitles and you end up with (ugly) default style with no options to customize it.
Jan 19, 2012
#5 subjunk
Support for ASS/SSA styling of non-ASS/SSA subtitles was recently restored to MEncoder
Status: WontFix
Jan 20, 2012
Project Member #6 happy.neko
I can confirm that -ass-force-style is NOT working in mencoder r34577 SB-21. However this is fixed in latest r34582. Related post: http://forum.doom9.org/showthread.php?p=1552741#post1552741

So I'll rewrite my patch with SSA rendering support for SRT subtitles (embedded and separate files).
Jan 20, 2012
#7 subjunk
Yep I'm planning a MEncoder release soon with the fix
Jan 22, 2012
Project Member #8 happy.neko
as promised new patches https://code.google.com/p/ps3mediaserver/issues/detail?id=1367
Sign in to add a comment

Powered by Google Project Hosting