Expose GetUmbrellaClassName in csharp_names.h #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!umbrellaNamespace.empty()) { | ||
| fullName = umbrellaNamespace + "." + umbrellaClassname; | ||
| result += umbrellaNamespace; |
There was a problem hiding this comment.
in one line:
result += umbrellaNamespace + ".";
|
LGTM |
|
Closing this in favor of #664 that be be merged to master. |
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
…shalers (protocolbuffers#656) PR protocolbuffers#650 added a check to error out when a custom marshaler was called and deterministic marshaling was also specified. That change performed the check in a relatively obscure location that did not catch all code paths. Since determinism can only be enabled on the Buffer type, we check it up front in Buffer.Marshal. Also, change the test to avoid code injection into generated sources.
adellahlou
pushed a commit
to adellahlou/protobuf
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be useful for gRPC protoc plugin to be able to expose ServiceDescriptor on each generated service class.
Also, the naming of umbrellaClass-related helper functions was pretty poor, so I did some refactoring and renaming.
@jskeet FYI