Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that C# code doesn't depend unnecessarily on field ordering #630

Closed
jskeet opened this issue Jul 21, 2015 · 1 comment
Closed
Labels

Comments

@jskeet
Copy link
Contributor

jskeet commented Jul 21, 2015

I have a nagging suspicion that we may sometimes be assuming field number order when we've actually got field declaration order instead.

Places where this is relevant:

  • Tying generated types to MessageDescriptors (messages rather than fields, so may not be a problem)
  • Serialization
  • JSON formatting

There may be no changes required, but we should validate that.

@jskeet jskeet added the c# label Jul 21, 2015
@jskeet
Copy link
Contributor Author

jskeet commented Aug 3, 2015

JSON formatting is now fixed (including oneofs) in 4fed0b5.
Tying generated types to message descriptors has been overhauled.
Serialization explicitly uses field number ordering already. Closing.

@jskeet jskeet closed this as completed Aug 3, 2015
taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant