Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install google/protobuf/stubs/strutil.h #626

Closed
wants to merge 1 commit into from
Closed

Install google/protobuf/stubs/strutil.h #626

wants to merge 1 commit into from

Conversation

earhart
Copy link

@earhart earhart commented Jul 20, 2015

No description provided.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jul 20, 2015

Why does this header need to be installed?

@earhart
Copy link
Author

earhart commented Jul 20, 2015

For now, we're using it for StrCat.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jul 21, 2015

I can understand that some users might find these utility functions useful, but as they are not part of protobuf public API, I think we shouldn't include them as public headers.

@earhart
Copy link
Author

earhart commented Jul 21, 2015

Ok -- thanks!

@earhart earhart closed this Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants