Assorted nits from C# code. #605
Conversation
| @@ -79,12 +79,6 @@ internal static InvalidProtocolBufferException InvalidEndTag() | |||
| "Protocol message end-group tag did not match expected tag."); | |||
| } | |||
|
|
|||
| internal static InvalidProtocolBufferException InvalidWireType() | |||
There was a problem hiding this comment.
Looks like unused code. Remove it?
|
I'm happy with all but removing the using statement. Will discuss that separately. |
|
Please look at #603 to find out some intesting things about the using statement and enumerator. |
| Assert.IsTrue(enumerator.MoveNext()); | ||
| Assert.AreEqual("first", enumerator.Current); | ||
| } | ||
| var enumerator = list.GetEnumerator(); |
There was a problem hiding this comment.
Ah, having read http://stackoverflow.com/questions/4642665 I see the issue.
I'll have a think about it. Another option could be to use a try/finally block manually, which might fix it.
Will certainly look at whether the mutable struct provides any benefit any more within the runtime - it still would for clients, in normal situations. (The capture here isn't particularly "normal"...)
jtattermusch
force-pushed
the
csharp_cleanup
branch
from
5206e50
to
b4a24aa
Compare
|
Rebased this one to not contain the fix from #603. Please merge this once happy. |
…type (protocolbuffers#612) Fix unmarshaling JSON object with escaped string into Struct type. Fixes protocolbuffers#605
Fixes #535.