Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce C# well-known types #594

Merged

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Jul 14, 2015

This PR does not do anything fancy with well-known types. In particular, we will want:

  • Wrapper type handling (possibly removing the codegen for wrapper types...)
  • Timestamp and duration partial classes, to introduce conversions to/from DateTimeOffset and TimeSpan
  • Handling of many types within JsonFormatter

... but all of that is yet to come.

@jtattermusch @anandolee

This involves:
- Specifying a namespace in each proto (including ones we'd previously missed)
- Updating the generation script
- Changing codegen to implement IReflectedMessage.Fields explicitly (a good thing anyway)
- Changing reflection tests to take account of the explicit interface implementation

Non-generated code in this commit; generated code to follow
@jtattermusch
Copy link
Contributor

LGTM.

jtattermusch added a commit that referenced this pull request Jul 15, 2015
@jtattermusch jtattermusch merged commit f828160 into protocolbuffers:csharp-experimental Jul 15, 2015
@jskeet jskeet deleted the csharp-wellknowntypes branch July 15, 2015 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants