Export c# naming routines publicly #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine by me, if it's okay in terms of C++ code (looks slightly odd to me that the functions declared in the .h file aren't implemented in a corresponding .cc file, although I know it's "correct"). No need for property names or anything like that? |
|
Java also has java_names.h without corresponding .cc file (so I figured its fine) gRPC only needs to refer to messages (from the service declaration), I think that would be the same for everyone that tries to implement a codegen for service stubs (which would be the main purpose of eposing these routines). |
|
@anandolee ping? |
|
LGTM |
jtattermusch
added a commit
that referenced
this pull request
Jul 17, 2015
Export c# naming routines publicly
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…_export Export c# naming routines publicly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose public header csharp_names.h that provides routines that will be used by gRPC codegen plugin
Fixes #522
@jskeet FYI