Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google.protobuf.Duration definition #559

Closed
dcarp opened this issue Jun 30, 2015 · 1 comment
Closed

google.protobuf.Duration definition #559

dcarp opened this issue Jun 30, 2015 · 1 comment

Comments

@dcarp
Copy link
Contributor

dcarp commented Jun 30, 2015

Considering that negative durations are very common, defining members as signed should be more space-efficient.

message Duration {
  sint64 seconds = 1;
  sint32 nanos = 2;
}
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 30, 2015

Hi @dcarp, although I think this is a good suggestion, the definition of these proto types are pretty much set in stone now. They are already used in production servers inside Google and we cannot afford changing it in an wire-incompatible way.

@xfxyjwf xfxyjwf closed this as completed Jun 30, 2015
taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
@dsnet
descriptor: fix example name (protocolbuffers#559)
e0ed903 
Example_Options is an example on the Options type or function.
Example_options is an example on the package with a suffix of "options".
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
@dcodeIO
Use extend module; Attempt to alias reserved js names in static codeg…
be3e0d9 
…en, see protocolbuffers#559; Some README
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
@dcodeIO
Fixed reserved names re, also ensure valid service method names, see p…
9b7b92a 
…rotocolbuffers#559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcarp @xfxyjwf