Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in utility.cc, invalid identifier ::isnan(value) #553

Closed
jmcauley opened this issue Jun 29, 2015 · 2 comments
Closed

Error in utility.cc, invalid identifier ::isnan(value) #553

jmcauley opened this issue Jun 29, 2015 · 2 comments

Comments

@jmcauley
Copy link

line 304 of utility.cc

if(::isnan(value)) return "NaN";

should be

if(std::isnan(value)) return "NaN";
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 29, 2015

std::isnan is from C++11. We probably should change that to MathLimits::IsNan(value).

@nslay
Copy link

nslay commented Jun 30, 2015

Also, please use MathLimits::IsFinite() instead of isfinite(). isfinite() does not exist in VS 2008 or 2010.

@xfxyjwf xfxyjwf closed this as completed Jan 21, 2016
taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
@neild
protoc-gen-go: don't generate blank // import comment (protocolbuffer…
b244a78 
…s#554)

Fix a bug which caused us to generate a blank import comment when go_package
contains just a package name (no import path):

  package foo // import ""

Fixes protocolbuffers#553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmcauley @nslay @xfxyjwf