Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The master branch and the v3.0.0-alpha-3 release cannot be compiled with the GOOGLE_PROTOBUF_NO_THREAD_SAFETY flag #548

Closed
waliwali opened this issue Jun 27, 2015 · 3 comments

Comments

@waliwali
Copy link

No description provided.

@abigailbunyan
Copy link

This is also the case with v2.6.1, and has been spotted previously here: https://groups.google.com/forum/#!topic/protobuf/poWwsDDUWYk

I'm about to make a pull request to fix this.

@davebranton
Copy link

This is still an issue with the latest 3.1.2 release. It appears that GOOGLE_PROTOBUF_NO_THREAD_SAFETY is simply no longer supported - in particular the arena allocator uses the atomic operations extensively.

I've modified my local copy to build, should I submit a patch, or is this being worked on?

@acozzette
Copy link
Member

@davebranton I'm not aware of anyone else actively working on this, so feel free to send a pull request if you have a fix for it.

@xfxyjwf xfxyjwf closed this as completed Dec 11, 2017
taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
…lbuffers#548)

This change effectively makes Go1.9 the minimum required version of Go
when using gRPC since type aliases are needed to truly unify context.
Even though this only affects those who use gRPC, there are other reasons we
need Go1.9 (such as type aliases for import public).

Fixes protocolbuffers#537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants