Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make distcheck for C# #541

Closed
jskeet opened this issue Jun 25, 2015 · 1 comment
Closed

Fix make distcheck for C# #541

jskeet opened this issue Jun 25, 2015 · 1 comment
Labels
c#
Milestone
C# code cleanup

Comments

@jskeet
Copy link
Contributor

jskeet commented Jun 25, 2015

The C# experimental branch fails the Travis "distcheck" build, because Makefile.am contains a bunch of references to files that don't exist.

Rather than hand-editing Makefile.am every time we add or remove a file from the protobuf runtime, we should automate it... but I don't want that to gate other feature work.
@jskeet jskeet added the c# label Jun 25, 2015
@jskeet jskeet added this to the C# code cleanup milestone Jun 25, 2015
@jskeet jskeet mentioned this issue Jun 25, 2015
Merged
@jtattermusch jtattermusch mentioned this issue Jul 16, 2015
Merged
@jtattermusch
Copy link
Contributor

I used the following script to generate the file list for csharp_EXTRA_DIST.
Not adding this as a script under csharp/ as the result needs to be pasted to Makefile.am manually (after removing the final backslash)

git ls-files csharp | grep -v .gitignore | awk '{ printf "  %-75s\\\n", $0 }'

taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
@neild
README: change minimum required Go version Go 1.6 (protocolbuffers#541)
1c9f675 
We're only testing with 1.6+, so claiming support for earlier versions is dubious.
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
@dcodeIO
Merge pull request protocolbuffers#541 from jonathon-love/master
2cdc316 
Fix to reflection documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c#
Projects
None yet
Milestone
C# code cleanup
Development

No branches or pull requests
2 participants
@jskeet @jtattermusch