Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upb to fix two bugs in the Ruby library. #530

Merged
merged 1 commit into from Jun 23, 2015

Conversation

haberman
Copy link
Member

Fixes:
#502
#425

@haberman
Copy link
Member Author

@xfxyjwf Feel free to take a quick look if you want, these changes were reviewed separately in the upb repo.

@haberman
Copy link
Member Author

Here are the PRs in the upb repo:
protocolbuffers/upb#29
protocolbuffers/upb#30

@haberman
Copy link
Member Author

Merging per @xfxyjwf

haberman added a commit that referenced this pull request Jun 23, 2015
Update upb to fix two bugs in the Ruby library.
@haberman haberman merged commit 242fdef into protocolbuffers:master Jun 23, 2015
@haberman haberman deleted the updateupb branch February 18, 2016 21:03
taoso pushed a commit to taoso/protobuf that referenced this pull request Aug 1, 2018
…rs#536)

As part of the recent protobuf optimization work, we started generating
Unmarshal and Marshal methods on generated messages. These were done to
support the table-driven implementation within the proto package.

We are renaming Marshal as XXX_Marshal and Unmarshal as XXX_Unmarshal
to make it clear that users are not supposed to call these directly.
There are several reasons for the rename:
* The Marshal method assumes that deterministic is the only option we
would ever support for protos, and is not very forward compatible.
* The presence of a deterministic boolean is confusing for users,
where many set it without considering whether it is necessary.
* The Unmarshal method has a slightly different semantic than the previously
documented proto.Unmarshaler interface. The documented Unmarshal specifies
that Reset is called, while the new method does no such thing. The semantic
difference warrants a rename of the method.
* Some users in the Go community depend on these methods not being
generated by default.

Fixes protocolbuffers#530
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
rinarakaki pushed a commit to rinarakaki/protobuf that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants