Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appveyor tests. #529

Merged
merged 1 commit into from Jun 22, 2015
Merged

Fix appveyor tests. #529

merged 1 commit into from Jun 22, 2015

Conversation

xfxyjwf
Copy link
Contributor

@xfxyjwf xfxyjwf commented Jun 22, 2015

To test appveyor.

@xfxyjwf xfxyjwf changed the title Trigger appveyor tests. Fix appveyor tests. Jun 22, 2015
@xfxyjwf xfxyjwf merged commit e359d0b into protocolbuffers:master Jun 22, 2015
@xfxyjwf xfxyjwf deleted the app branch June 22, 2015 21:45
taoso pushed a commit to taoso/protobuf that referenced this pull request Aug 1, 2018
In the case of a tag of zero, we perform some pointer arithmetic
where we add -1 to the pointer. Even though we do not end up dereferencing
the pointer, this still causes issues with the Go GC, which expects that
every Go pointer is a valid pointer.

This causes crashes on Go1.7 and below because the function arguments
are considered live throughout the entire function causing the GC to
scan this invalid pointer. On Go1.8 and above, this is not an issue
since the argument is not considered live and is not scanned.

To be on the safer side, perform pointer arithmetic that is effectively
a noop, so that we don't cause a valid pointer to become invalid.
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants