Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf, GG_ULONGLONG & android ndk #526

Closed
srenault opened this issue Jun 22, 2015 · 4 comments
Closed

Protobuf, GG_ULONGLONG & android ndk #526

srenault opened this issue Jun 22, 2015 · 4 comments

Comments

@srenault
Copy link

Trying to compile protobuf using ndk compiler:

https://github.com/google/protobuf/blob/master/src/google/protobuf/stubs/common.h#L1462

I have got an error saying that 'GG_ULONGLONG' isn't declared.

Alter 'GG_ULONGLONG' to 'GOOGLE_ULONGLONG' actually fix the compile error.

What do you think ?

@iphydf
Copy link

iphydf commented Jun 26, 2015

I think fix it. https://github.com/google/protobuf/blob/master/src/google/protobuf/stubs/common.h#L229 was probably GG_ULONGLONG before.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 29, 2015

You guys are right. GG_ULONGLONG should be GOOGLE_ULONGLONG.

@jmcauley
Copy link

I can confirm that this prevented me from compiling on Windows and that changing it to GOOGLE-ULONGLONG seems to have fixed the issue.

@iphydf
Copy link

iphydf commented Jul 18, 2015

This is now fixed: ee35402.

@xfxyjwf xfxyjwf closed this as completed Jan 20, 2016
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
rinarakaki pushed a commit to rinarakaki/protobuf that referenced this issue Aug 30, 2023
Added fuzzing of symtab build, and fixed a handful of minor bugs.
bithium pushed a commit to bithium/protobuf that referenced this issue Sep 4, 2023
Added fuzzing of symtab build, and fixed a handful of minor bugs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants