Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# review: Improve string encoding times #517

Closed
jtattermusch opened this issue Jun 19, 2015 · 1 comment
Closed

C# review: Improve string encoding times #517

jtattermusch opened this issue Jun 19, 2015 · 1 comment
Labels
c#
Milestone
C# code cleanup

Comments

@jtattermusch
Copy link
Contributor

This has already been merged by #515 to csharp-experimental, but would need a second pass review:
jskeet@35e4dbd
@jtattermusch jtattermusch added this to the C# code cleanup milestone Jun 19, 2015
@jtattermusch
Copy link
Contributor Author

Re-reviewed the GetByteCount() == string.Length optimization today and everything looks alright.

rinarakaki pushed a commit to rinarakaki/protobuf that referenced this issue Aug 30, 2023
@fowles
Merge pull request protocolbuffers#517 from fowles/main
663a35f 
Fixes for more strict build evnironments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c#
Projects
None yet
Milestone
C# code cleanup
Development

No branches or pull requests
1 participant
@jtattermusch