Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OUTS constants in BUILD #510

Merged
merged 1 commit into from Jun 18, 2015
Merged

Conversation

liujisi
Copy link
Contributor

@liujisi liujisi commented Jun 18, 2015

Induce those from the input proto file names instead to reduce the
lenght of the BUILD file.

Induce those from the input proto file names instead to reduce the
lenght of the BUILD file.

Change-Id: I1dda57dedac547f4bd0cc3a7d08fb611d72acd13
@liujisi
Copy link
Contributor Author

liujisi commented Jun 18, 2015

@xfxyjwf

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 18, 2015

LGTM

liujisi added a commit that referenced this pull request Jun 18, 2015
Remove OUTS constants in BUILD
@liujisi liujisi merged commit 5b3a8e7 into protocolbuffers:master Jun 18, 2015
taoso pushed a commit to taoso/protobuf that referenced this pull request Aug 1, 2018
As mentioned in protocolbuffers#509, jsonpb panics when marshaling/unmarshaling a non-generated message that has an unexported pointer field. This change will restore dynamic messages to working with jsonpb (they work fine in master; just broken in this dev branch as of protocolbuffers#472).
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
…num value options (no wrapper), fixes protocolbuffers#510; expose zero on LongBits, fixes protocolbuffers#508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants