Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using ::isnan to avoid conflicts with std::isnan for C++11 build. #508

Merged
merged 1 commit into from Jun 18, 2015

Conversation

liujisi
Copy link
Contributor

@liujisi liujisi commented Jun 18, 2015

No description provided.

Change-Id: I057b44eff04c3b0062a4fd4307ce6e4ca1eb952b
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 18, 2015

LGTM

liujisi added a commit that referenced this pull request Jun 18, 2015
using ::isnan to avoid conflicts with std::isnan for C++11 build.
@liujisi liujisi merged commit d6286a9 into protocolbuffers:master Jun 18, 2015
@liujisi liujisi deleted the nanfix branch June 18, 2015 20:38
taoso pushed a commit to taoso/protobuf that referenced this pull request Aug 1, 2018
…uffers#508)

In Go 1.10, go vet and gofmt have changed their output in a way to breaks the current build and test cycle.

gofmt turns a one-line definition of a single-method interface into three lines; this causes a golden
comparison test to produce different results between Go 1.9 and Go 1.10.
go vet is now run by default with go test, which uncovered a bad Stringer argument in extension_test.go.
Tested on Go1.10rc1 and Go1.9.3.
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
…num value options (no wrapper), fixes protocolbuffers#510; expose zero on LongBits, fixes protocolbuffers#508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants