Add bazel support for the project #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Idecb2e3a5169f7b40d832242c9c10b0eb4325654
Change-Id: I5a299d969ff96d7d2f80aadc7e8987d461d24b8f
|
@xfxyjwf for review. |
|
LGTM |
Change-Id: I62640af99e3c2650a29dc5468ce3deb7b6c7efdf
liujisi
added a commit
that referenced
this pull request
Jun 18, 2015
Add bazel support for the project
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
In Go 1.10, go test automatically runs go vet as well. This uncovered a vet failure in TestUnmarshalRepeatingNonRepeatedExtension where pb.ComplexExtension is passed as a fmt.Stringer to t.Errorf. The string method exists only on the pointer-receiver type, *pb.ComplexExtension.
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Moved tests into the main source tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move and updated the cmake/update_file_lists.sh to also update the BUILD file.
Need to manage gtest external deps to enable cc_test; will do in a different PR.