Update podspec, rename assets to drop @ #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
liujisi
added a commit
that referenced
this pull request
Jun 10, 2015
Update podspec, rename assets to drop @
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
…ers#486) Change the pre-gofmt generated code for oneof discriminant interfaces from: type T interface { T() } to: type T interface { T() } Prior to Go 1.9, gofmt rewrote the single-line form into the multi-line one. Go 1.10 and later preserve the single-line form for single-method interfaces. Generating code that is handled identically by both versions of gofmt avoids spurious diffs with golden test data. Change-Id: Ibb229827823a50e963bcd1b34e59a286654b415f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update podspec for files that can build now.
Rename assets to not need @ in the name.