Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude 3 failing tests on osx from travis. #476

Merged
merged 1 commit into from Jun 8, 2015

Conversation

xfxyjwf
Copy link
Contributor

@xfxyjwf xfxyjwf commented Jun 8, 2015

It seems travis start to run osx tests for our project only very recently and since then 3 tests on osx have always been failing:

osx is added to .traivis.yml here: #248

the first failing test occurred in this build: https://travis-ci.org/google/protobuf/builds/65636924

This PR lists these failing tests as "allowed_failures" so they don't block new submissions.

@xfxyjwf
Copy link
Contributor Author

xfxyjwf commented Jun 8, 2015

@jtattermusch , @haberman to review.

@haberman
Copy link
Member

haberman commented Jun 8, 2015

LGTM

1 similar comment
@jtattermusch
Copy link
Contributor

LGTM

@xfxyjwf xfxyjwf merged commit 9cbdaed into protocolbuffers:master Jun 8, 2015
@xfxyjwf xfxyjwf deleted the exclude_travis_tests branch July 13, 2016 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants