Fixes map fields' behavior when used with arena. #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xfxyjwf
commented
Jun 3, 2015
xfxyjwf
commented
- Implemented NewDeleteCapture to detect heap allocations.
- Made MapField allocate mutexs lazily so generated API will not cause any heap allocation when using arena.
- Added a type trait Arena::is_destructor_skippable to check whether an object's destructor can be skipped when used with arena. Removed some incorrectly marked DestructorSkippable_ typedef.
Changed MapField to allocate mutex lazily and removed some incorrectly used DestructorSkippable_.
Currently the parsing code of lite messges will store unknown fields in a string object that is not allocated in the arena. Before that bug is fixed, heap check will fail for arena lite runtime tests.
|
Added a new commit to disable heap check for arena lite runtime tests. These tests will fail because of #445 |
|
@TeBoring to review |
| @@ -495,6 +495,20 @@ class LIBPROTOBUF_EXPORT Arena { | |||
| static const type value; | |||
| }; | |||
|
|
|||
| template<typename T> | |||
There was a problem hiding this comment.
We already have this internally.
|
@xfxyjwf to reply new comments |
|
As you have already made part of this change in our internal code base, I'll hold this PR until next down-integration when I'll merge and update the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.