Add protoc path detection for Mac OS #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. One travis test (for jruby) failed though. Could you check whether it's related to this change? (run ./travis.sh jruby to verify if it passes locally). |
|
I just ran the jruby tests locally and they passed, so it looks like the test failure is unrelated. |
|
Thanks for confirming! |
xfxyjwf
added a commit
that referenced
this pull request
Jun 3, 2015
Add protoc path detection for Mac OS
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
…aling durations (protocolbuffers#453)" (protocolbuffers#493) The change does not handle negative values correctly. This reverts commit 1e59b77.
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Add protoc path detection for Mac OS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Mac OS support to the default import path feature added in #411.