Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching for sched_yield fails on MinGW. #45

Closed
xfxyjwf opened this issue Oct 10, 2014 · 3 comments · Fixed by #48
Closed

Searching for sched_yield fails on MinGW. #45

xfxyjwf opened this issue Oct 10, 2014 · 3 comments · Fixed by #48
Milestone
Release 2.6.1

Comments

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 10, 2014

The following line causes a ./configure failure on MinGW:

# Need to link against rt on Solaris
AC_SEARCH_LIBS([sched_yield], [rt], [], [AC_MSG_FAILURE([sched_yield was not found on your system])])

It's specific to Solaris and should be moved to m4/acx_check_suncc.m4
@xfxyjwf xfxyjwf added this to the Release 2.6.1 milestone Oct 10, 2014
@xfxyjwf
Copy link
Contributor Author

xfxyjwf commented Oct 10, 2014

@worr, could you help fix this issue?

@worr
Copy link
Contributor

worr commented Oct 10, 2014

I'm not sure that that's the right solution here. Technically, sched_yield is required on every platform except Windows. It makes more sense to just disable the check on any Win32 platforms, rather than enable it only for Solaris. On non-Windows, non-Solaris systems, this guarantees the presence of sched_yield

@xfxyjwf
Copy link
Contributor Author

xfxyjwf commented Oct 10, 2014

@worr, your suggestion sounds good to me. Can you help make this change? (i.e., disable the change on Win32).

@worr worr mentioned this issue Oct 11, 2014
Merged
TeBoring pushed a commit to TeBoring/protobuf that referenced this issue Jan 19, 2019
@haberman
Merge pull request protocolbuffers#45 from mbarbon/fix-status-init
002f57f 
Make sure upb_pbdecoder.status is initialized
@arnow117 arnow117 mentioned this issue Apr 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6.1
Development

Successfully merging a pull request may close this issue.

Don't test for sched_yield on Windows worr/protobuf
2 participants
@worr @xfxyjwf