Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate C# generator from writer to io::Printer #448

Closed
anandolee opened this issue Jun 1, 2015 · 1 comment
Closed

Migrate C# generator from writer to io::Printer #448

anandolee opened this issue Jun 1, 2015 · 1 comment
Labels

Comments

@anandolee
Copy link
Contributor

Current C# generator is using writer. I will change to use io::Printer like other languages, it will have better readability.

@jskeet
Have you begin the "simplify generate members" task? Is the conflict accept for you?
I guess you are not working on mutable for the generator part?

Protobuf like to have the proto3 support for C# ASAP. It will be good if we could make the things faster that blocks proto3.

@anandolee anandolee added the c# label Jun 1, 2015
@jskeet
Copy link
Contributor

jskeet commented Jun 1, 2015

Assuming it's simple to apply the changes to use io::Printer, I'm sure it won't be a problem - the work I'm prototyping is for more than just "simplify generate members", it's for the whole codegen and runtime, but it's worth you doing the io::Printer stuff first, while we work out exactly what the plan is for the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants